Merging KeyValueProperty and NameValuePair
#1532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659
KeyValuePropertyandNameValuePairare both data schema's defining a String and a value, though they are incompatible and are used interchangeably in different parts of the library. The only difference was the name for the key (eitherkeyorname) and the fact that one is an interface and the other a data class.This PR brings them closer together:
NameValuePairinheritKeyValuePropertynamein favor ofkeyAt a later stage we can deprecate
NameValuePairand introduce an instantiableKeyValuePropertywith a better name.@Allex-Nik
NameValuePairis marked@RequiredByIntellijPlugin. Do you think these changes will cause issues?